Request for review: 7098155: Resize young gen at full collections for UseParallelGC

Thomas Schatzl thomas.schatzl at
Thu Nov 21 09:41:08 UTC 2013


On Wed, 2013-11-13 at 13:40 -0800, Jon Masamitsu wrote:
> Changes look good.
> On 11/13/2013 10:48 AM, Tao Mao wrote:
> > Hi Jon,
> >
> > New webrev is uploaded.
> >
> >
> > I think it makes even more sense to guard the piece of code under 
> > (UseAdaptiveGenerationSizePolicyAtMajorCollection...etc.)
> Agreed.  I didn't mean to imply any differently.

Looks okay, some comments:

- that UseAdaptiveSizePolicyResizeYoungGenAtMajorCollection (what a
name :) flag seems to be a very exotic knob to turn (to me :). Is it
better to make it experimental or diagnostic? Maybe this would allow
removing it later more easily, especially if it is experimental.

Especially if the default is true anyway.

- I diffed the parts of the code from the "if
(UseAdaptiveSizePolicy)..." in
psParallelCompact.cpp:2102/psMarkSweep.cpp:265 policy" to the closing
brace of that if statement and there was no difference at all except
some indentation.

Are there some plans to move that code to the adaptive size policy
(because almost all calls start with "size_policy->") at some point? I
find it hard to keep the code in sync, but likely you are already used
to it.


More information about the hotspot-gc-dev mailing list