RFR(S): 8040807: G1: Enable G1CollectedHeap::stop()

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jun 3 07:15:54 UTC 2014


On Tue, 2014-05-27 at 13:15 +0200, Per Liden wrote:
> Hi,
> I did some additional testing and eyeballing of this fix and noticed 
> that it would be a good idea to also tell concurrent mark to abort, 
> otherwise we will always wait until concurrent mark has finished, which 
> is unnecessary (and could potentially take some time if the live set is 
> large). So, I added a call to _cm->set_has_aborted() to abort any 
> ongoing concurrent mark.
> Updated webrev:
> http://cr.openjdk.java.net/~pliden/8040807/webrev.1/
> Diff against previous webrev:
> http://cr.openjdk.java.net/~pliden/8040807/webrev.diff_0vs1/
> Testing:
> Wrote a simple test to provoke an concurrent mark followed by an 
> immediate exit. With the first version of the patch, we would always 
> wait until concurrent mark completes. Now it will instead show an 
> concurrent-mark-abort, which happens much earlier.

Looks okay.


More information about the hotspot-gc-dev mailing list