RFR(S): JDK-8047330: Remove unrolled card loops in G1 SparsePRTEntry

Mikael Gerdin mikael.gerdin at oracle.com
Mon Jun 23 14:51:54 UTC 2014

Hi Andreas,

On Thursday 19 June 2014 15.27.23 Andreas Sjöberg wrote:
> Hi all,
> can I please have reviews for this patch that removes the unrolled
> for-loops in sparsePRT.cpp.
> I ran some performance benchmarks and could not see any benefits in
> keeping the unrolled for loops. SPECjbb2013 shows a 3.48% increase on
> Linux x64 actually.
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8047330/webrev/

It looks like you can remove the define as well:
  36 #define UNROLL_CARD_LOOPS  1

UnrollFactor should also be useless now, but it seems like it's being used to 
align up the number of cards. I suggest you leave UnrollFactor for a second 


> Testing: jprt, specjbb2005, specjvm2008, specjbb2013
> Thanks,
> Andreas

More information about the hotspot-gc-dev mailing list