RFR: 8048214: Linker error when compiling G1SATBCardTableModRefBS after include order changes

Stefan Karlsson stefan.karlsson at oracle.com
Thu Jun 26 11:28:45 UTC 2014

On 2014-06-26 13:33, Mikael Gerdin wrote:
> Hi all!
> A small build issue occurs with the change for 8047818 due to some strange
> include order effects.
> The symptom is that a template function in G1SATBCardTableModRefBS is not
> instantiated when compiling on Windows and the link of jvm.dll fails.
> Since 8047818 is already reviewed and is a change we want to keep separate I'd
> like to push the fix for this issue before 8047818 instead of folding it into
> that change.
> My suggested fix is to move the implementations of the callers of the template
> function into the cpp file as well. They override virtual functions so they
> should not have been inlined in the first place (since we always call through
> a base class pointer to the BarrierSet).
> Webrev: http://cr.openjdk.java.net/~mgerdin/8048214/webrev

Looks good.


> Bug: https://bugs.openjdk.java.net/browse/JDK-8048214
> Thanks
> /Mikael

More information about the hotspot-gc-dev mailing list