RFR (S): 8043243: convert SCAN_AND_FORWARD, SCAN_AND_ADJUST_POINTERS, SCAN_AND_COMPACT macros to methods
mikael.gerdin at oracle.com
Thu Oct 30 10:14:51 UTC 2014
On 2014-10-27 15:29, Marcus Larsson wrote:
> Hi again,
> Apparently MSVC has some problems with the inline keyword and friend
> declarations on the specialized function templates, and therefore the
> latest patch wouldn't compile on windows. Resolved this by making the
> friend declarations non-specialized.
> Now builds & runs fine on all platforms in JPRT.
> New webrev:
Excellent cleanup and thanks for taking this the extra mile with through
all the discussions.
> On 27/10/14 09:26, Marcus Larsson wrote:
>> On 24/10/14 20:18, Kim Barrett wrote:
>>> [Didn’t like my ScanSupport helper class? Well, it was an interesting
>>> little exercise for me anyway.]
>> I wanted to avoid CRTP solutions for now. Your sketch might be a good
>> reference for possible future changes though.
>>> This latest version looks good.
>> Thank you for the review!
More information about the hotspot-gc-dev