Request for code review - JDK-8141123 Change int's to size_t in FreeIdSet

Kim Barrett kim.barrett at
Wed Dec 2 01:33:35 UTC 2015

On Dec 1, 2015, at 8:23 PM, Kim Barrett <kim.barrett at> wrote:
> On Dec 1, 2015, at 6:45 PM, Kim Barrett <kim.barrett at> wrote:
>> However, given that we've apparently never had any callers of
>> set_safepoint, it is perhaps OK to go ahead and remove it, and have
>> additional followups to look into the various issues mentioned here.
> Yet more problems with the existing code.
> A FreeIdSet is constructed with a pointer to a Monitor, which is used
> to protect it.  The Monitor that is provided for the FreeIdSet used by
> DirtyCardQueueSet is the Shared_DirtyCardQ_lock, which is actually a
> Mutex.  

No, I take this back.  Wrong lock…

More information about the hotspot-gc-dev mailing list