RFR (XXS) JDK-8139871 G1CollectorPolicy::_cur_mark_stop_world_time_ms is never read from

Stefan Karlsson stefan.karlsson at oracle.com
Wed Dec 9 19:48:58 UTC 2015


Hi Joe,

On 2015-12-09 19:31, Joseph Provino wrote:
> Please review this very small change.  It's removal of unneeded code.
>
> CR:  https://bugs.openjdk.java.net/browse/JDK-8139871
>
> Webrev:  http://cr.openjdk.java.net/~jprovino/8139871/webrev.00

The mark_init_elapsed_time_ms parameter seems unused now:

   void G1CollectorPolicy::record_concurrent_mark_init_end(double
                                                      mark_init_elapsed_time_ms) {
     collector_state()->set_during_marking(true);
     assert(!collector_state()->initiate_conc_mark_if_possible(), "we should have cleared it by now");
     collector_state()->set_during_initial_mark_pause(false);
-   _cur_mark_stop_world_time_ms = mark_init_elapsed_time_ms;
   }

Otherwise, this looks good.


For future reviews, could you use the official webrev script at:
http://hg.openjdk.java.net/code-tools/webrev/

The udiffs view is broken in the version your are using.

Thanks,
StefanK
>
> joe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151209/50fbe1e9/attachment.htm>


More information about the hotspot-gc-dev mailing list