RFR (S): 8143215: gcc 4.1.2: fix three issues breaking the build.

Kim Barrett kim.barrett at oracle.com
Thu Dec 10 23:58:48 UTC 2015

On Dec 10, 2015, at 4:18 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> Hi,
> Seeing Mikaels mail, I did not convert the computation in 
> g1IHOPControl.cpp:145 ff.

OK.  I’ll file an RFE for that.

> I changed though the computations in gcTraceSend.cpp.
> Please check whether I should move the division to 
> be performed before the multiplication.

I checked these, and they are ok in your latest version.

> See more comments inline below.
> New webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8143215-gcc412/webrev.03/index.html

Looks good.

>> get_new_size_prediction?  get_predicted_size?  Let the bikeshedding
>> begin!
> I introduced get_new_size_prediction() as Mikael said.

Mikael => Thomas.

More information about the hotspot-gc-dev mailing list