JDK-8145303: Clean up the units for log_gc_footer

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Dec 14 10:57:12 UTC 2015

Hi Bengt, 

thanks for doing a real fix for this.  Looks good (and works with gcc 4.1.2).
I'll remove my patch for g1CollectedHeap.cpp from my 
webrev for 8143215: gcc 4.1.2: fix three issues breaking the build.

Thanks a lot!

> -----Original Message-----
> From: hotspot-gc-dev [mailto:hotspot-gc-dev-bounces at openjdk.java.net]
> On Behalf Of Bengt Rutisson
> Sent: Montag, 14. Dezember 2015 10:42
> To: hotspot-gc-dev at openjdk.java.net
> Subject: RFR: JDK-8145303: Clean up the units for log_gc_footer
> Hi everyone,
> Could I have a couple of reviews for this small patch?
> http://cr.openjdk.java.net/~brutisso/8145303/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8145303
> The log_gc_footer() method takes one parameter of type double. But it
> should be jlong. It also converts to seconds but farther down the call
> chain we convert to milliseconds.
> Thanks,
> Bengt

More information about the hotspot-gc-dev mailing list