RFR(s): 8144949: TestOptionsWithRanges -XX:NUMAInterleaveGranularity=2147483648 crashes VM
sangheon.kim at oracle.com
Tue Dec 15 23:10:08 UTC 2015
Could I get some reviews for this change?
Current 32bit binary with NUMAInterleavingGranularity=2g on server mode
fires an assert on Windows as we are proceeding without memory
allocation failure check at CodeCache::reserve_heap_memory.
I think the constraint function can be removed with maximum range of
2G/8192G. These are the maximum available memory on Windows and smaller
values can be used but I wanted to avoid adding artificial limit. With
this limitation, current constraint function for overflow check is not
And we need to check allocation failure.
This issue is not reproducible with client mode as the different default
value of ReservedCodeCacheSize sets SegmentedCodeCache to false. And
CodeCache::reserve_heap_memory() is called only when SegmentedCodeCache
Skipped adding a test as TestOptionsWithRanges.java is enough when this
is combined with nightly vm option rotation.
Testing: JPRT (with TestOptionsWithRanges.java enabled), manual tests on
Windows machine(to test several option combination).
More information about the hotspot-gc-dev