Request for review (s) - 8145031: Add regression test for 8133023
tom.benson at oracle.com
Wed Dec 16 15:45:56 UTC 2015
This looks OK to me (modulo Thomas' comments), but it's not clear to me
why a unit test is needed for this case, rather than a simple assert
somewhere, such as when the threads are created. Thanks,
On 12/15/2015 2:01 PM, Jon Masamitsu wrote:
> On 12/15/2015 2:24 AM, Thomas Schatzl wrote:
>> Hi Jon,
>> On Thu, 2015-12-10 at 11:50 -0800, Jon Masamitsu wrote:
>>> The cause of the failure in 8133023 was the calculation of the
>>> ParallelGCThreads using
>>> information that had not yet been initialized. Add a test that checks
>>> that, after full
>>> initialization, the fresh calculation of ParallelGCThreads is
>>> consistent with the value
>>> calculated earlier.
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8145031
>>> Tested with and without the fix for 8133023.
>> seems okay, with one nit: the indendation of the parameters for the
>> assert in Abstract_VM_Version::FinalParallelGCThreads_test() seems off.
>> Also there is an extra space between the "void" and the method name.
> Both fixed. Thanks.
>> I do not need to re-review.
More information about the hotspot-gc-dev