RFR (S): 8145534: TestRemsetLogging.java takes a long time
bengt.rutisson at oracle.com
Thu Dec 17 07:28:25 UTC 2015
Thanks for fixing this!
Changes look good except that I think TestRemsetLogging.java should have
the same @requires tag as the other tests.
@requires vm.gc=="G1" | vm.gc =="null"
Also, I think the 100 seconds runtime that you got may be related to the
fastdebug/slowdebug issue that the changes to the configure scripts
The numbers I reported in the bug report (18 seconds) are from my
workstation without the slowdebug problem.
If I run with your changes I get:
elapsed time (seconds): 4.391
Which is a great improvement and an acceptable execution time I think.
On 2015-12-16 18:18, Thomas Schatzl wrote:
> Hi all,
> can I have reviews for the following changes to gc/g1/TestRemset*
> tests that decrease its runtime significantly?
> Most of the runtime improvements come from using WhiteBox methods to
> start gcs (instead of allocating objects and waiting for it to happen),
> then forcing that test to use the interpreter (because starting up the
> compilers only slows it down), and some measures to improve startup.
> In total all this decreases fastdebug VM runtime from 100s to 17s on my
> local machine.
> The changes also add @requires tags and deletes equivalent java code.
> looking at run times of jprt jobs which are much better now. There is
> still some variation, but they are in the same range as other tests now.
More information about the hotspot-gc-dev