RFR (S): 8145534: TestRemsetLogging.java takes a long time
dmitry.fazunenko at oracle.com
Thu Dec 17 11:33:14 UTC 2015
Thanks for explanation. New version looks good to me.
One a very tiny comment about TestRemsetLoggingThreads.java
* @library /testlibrary /test/lib
* @library /testlibrary
I don't need a new webrev for that.
On 17.12.2015 14:08, Thomas Schatzl wrote:
> Hi Dima,
> On Wed, 2015-12-16 at 21:12 +0300, Dmitry Fazunenko wrote:
>> Hi Thomas,
>> 1) TestRemsetLoggingPerRegion.java
>> there are unused imports, you can remove them
>> 2) TestRemsetLoggingThreads.java
>> it doesn't use TestRemsetLoggingTools, just -version.
>> So, you don't need WB here and you don't need to build
>> TestRemsetLoggingTools TestRemsetLoggingThreads
>> 3) TestRemsetLoggingTools.java
>> You changed the logic of the test:
>> - replaced "1 young GC + N full GC" with "N young GC + 1 full GC"
>> - removed all object allocations
>> So, now VerifySummaryOutput just invokes serveral GC.
>> Did you do this intentionally or by mistake?
> Intentionally. The idea is to run one gc of every kind. If the user
> specified to run only one gc, it does not matter.
> The expected messages are printed for any kind of gc.
> Young gcs on an empty heap are just slightly faster than full gcs.
> The test also does not check particular object allocation, just that
> some messages exist. Previously the allocations with the goal to run
> young gcs only. There is no difference on whether there are actually any
> kind of survivors.
> New webrev at http://cr.openjdk.java.net/~tschatzl/8145534/webrev.1
> (sorry no diff, I messed up)
More information about the hotspot-gc-dev