RFR (XS): 8145674: Fix includes and forward declarations in g1Remset files

Stefan Karlsson stefan.karlsson at oracle.com
Fri Dec 18 11:53:54 UTC 2015

Hi Thomas,

On 2015-12-18 11:48, Thomas Schatzl wrote:
> Hi all,
>    can I have reviews for this change that adds necessary includes and
> forward declarations in g1RemSet.?pp files? While it compiles right now
> as is, if something changes in this area, compilation tends to break in
> interesting ways.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8145674
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8145674/webrev/

Looks good.

It's a bit unfortunate that you have to include heapRegion.hpp. Maybe we 
should break out HeapRegionClosure out of heapRegion.hpp?


> Testing:
> jprt
> Thanks,
>    Thomas

More information about the hotspot-gc-dev mailing list