RFR: JDK-8072725: Provide more granular levels for GC verification
jon.masamitsu at oracle.com
Tue Dec 22 15:43:52 UTC 2015
On 12/21/2015 4:40 PM, Poonam Bajaj Parhar wrote:
> Hello Jon,
> On 12/21/2015 2:29 PM, Jon Masamitsu wrote:
>> Some of the string list parameters allow separation by , or " ". Did
>> you consider adding that?
> The VerifySubSet string list can accept the strings separated by comma
> or a space. Before verification, we just need to check if a particular
> subset is present in the VerifySubSet list or not. We don't need any
> complicated processing of the strings list here.
Ok. Thanks for the explanation.
You mention in the RFR that you have a simple test to test the
change. Can you add that as a jtreg test? I'm thinking about
>> PS. See share/vm/compiler/compilerDirectives.cpp
>> ccstrlist DirectiveSet::canonicalize_disableintrinsic(ccstrlist
>> On 12/15/2015 03:15 PM, Poonam Bajaj Parhar wrote:
>>> Please review these changes that split up the work done under
>>> Verify*GC options. This will be very useful in debugging GC
>>> issues/crashes where verifying the whole memory system with
>>> Verify*GC options slows down the process and makes it impossible to
>>> reproduce the problem.
>>> The changes introduce a new option /VerifySubSet///that can be used
>>> to specify the specific memory sub-systems that one wants to verify.
>>> It can be one or more of the sub-systems from these: threads, heap,
>>> symbol_table, string_table, codecache, dictionary,
>>> classloader_data_graph, metaspace, jni_handles, c-heap and
>>> codecache_oops. If nothing is specified with /VerifySubSet/ then
>>> whole of the memory system is verified with Verify*GC options.
>>> Bug:JDK-8072725: <https://bugs.openjdk.java.net/browse/JDK-8072725>
>>> Provide more granular levels for GC verification
>>> Webrev: http://cr.openjdk.java.net/~poonam/8072725/webrev.00/
>>> Testing: JPRT, tested the changes with a simple test program.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev