RFR(s): 8144527: NewSizeThreadIncrease would make an overflow
sangheon.kim at oracle.com
Wed Dec 23 17:06:09 UTC 2015
Hi Michail again,
I thought previous versions are fine, but they aren't.
I know that it will not work and this is why I temporarily moved to
below line for local test. But I will fix it before push.
On 12/23/2015 07:44 AM, sangheon.kim at oracle.com wrote:
> Hi Michail,
> Thanks for the comment.
>> On Dec 23, 2015, at 4:11 AM, Michail Chernov <michail.chernov at oracle.com> wrote:
>> Hi Shangheon,
>> Could you please fix @requires tag. Should be: @requires vm.gc=="Serial" | vm.gc=="null"
> In this test, only serial gc is needed.
> Still 'null' is necessary?
>> Also @requires tag should be placed with other tag in one /*..*/ comment, otherwise it doesn't work, see http://openjdk.java.net/jtreg/tag-spec.html#LEADING_COMMENTS .
> This is leftover for local test. :)
> All previous webrev versions were correct but not this one.
>>> To make sure, I'm posting next webrev which includes Mikael's comment.
>>> Webrev: http://cr.openjdk.java.net/~sangheki/8144527/webrev.02
>>> Testing: JPRT
More information about the hotspot-gc-dev