[8u60] (XS) RFR: 8071972: Minimal VM is broken
david.holmes at oracle.com
Wed Feb 4 09:27:23 UTC 2015
On 4/02/2015 7:12 PM, Stefan Karlsson wrote:
> Hi David,
> On 2015-02-02 05:51, David Holmes wrote:
> Looks fine.
> Some bikeshedding: we usually don't add newlines between the sections in
> the include list:
> 35 #include "utilities/macros.hpp"
> 37 #if INCLUDE_ALL_GCS
> 38 #include "gc_implementation/shared/parGCAllocBuffer.hpp"
> 39 #endif
> so I'd prefer if you removed lined 36.
Thanks for the Reviews.
>> Original bug is confidential but the backport issue is not:
>> Simple fix to ensure header inclusion is guarded based on all GCs
>> being included.
>> This fix is not applicable to 9 due to the changes there that have
>> removed the parNew and defNew support. In fact inclusion of this
>> header is no longer needed in 9 and I've filed
>> to clean that up.
More information about the hotspot-gc-dev