Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

Kim Barrett kim.barrett at
Wed Nov 18 00:27:58 UTC 2015

On Nov 17, 2015, at 6:44 PM, Jon Masamitsu <jon.masamitsu at> wrote:
> On 11/17/2015 02:31 PM, Kim Barrett wrote:
>> On Nov 17, 2015, at 4:12 PM, Jon Masamitsu <jon.masamitsu at> wrote:
>> Shouldn’t the assert be at the beginning of VM_Version::initialize, rather than some distance into it.
>> There are some _features-based predicates being called before that assert on line 63:
> Yes, that would be good.  What about the guarantee().  Some of the other variables depend on
> has_v9().

Does anything before the has_v9() guarantee require v9?  It’s not even slightly obvious to me.
OTOH, giving up sooner when we’re going to be giving up anyway is probably better.

More information about the hotspot-gc-dev mailing list