RFR(S): 8164028: Convert TestPredictions_test to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Wed Aug 17 15:49:33 UTC 2016


Thank you for reviewing the fix!
I changed test names to snake_case.

Here are a new WebRev: 

Regards, Kirill

On 17.08.2016 18:08, Erik Helin wrote:
> On 2016-08-17, Kirill Zhaldybin wrote:
>> Dear all,
>> Could you please review this fix for JDK-8164028?
>> The test was converted to gtrest, a couple of wrong checks fixed.
>> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164028/webrev.00/
> It seems like most the unit tests in hotspot/test/native uses
> "snake_case" for naming the tests, whereas you are using "camelCase".
> Would you mind changing to "snake_case" so the test names are
> consistent?
> Thanks,
> Erik
>> CR: https://bugs.openjdk.java.net/browse/JDK-8164028
>> Thank you.
>> Regards, Kirill

More information about the hotspot-gc-dev mailing list