RFR(S): 8164028: Convert TestPredictions_test to GTest
erik.helin at oracle.com
Mon Aug 22 15:13:41 UTC 2016
On 2016-08-22, Kirill Zhaldybin wrote:
> I deleted some comments, please do not hesitate me if you think I deleted
> too much.Here are a new WebRev:
> >>Could you please read comments inline?
> >>- Looking at the unified diff (much easier now, thanks) it seems like
> >> the old code used <, which means that the new code must use ASSERT_GE,
> >> not ASSERT_GT.
> >>Sorry, I did not find a line you mentioned. Could you please let me know the
> >>line number?
> >Just look at the unified diff:
> >Everywhere you see a pattern similar to:
> >- assert(p2 < p1, "First prediction must be larger than second, but they are %f %f", p1, p2);
> >+ ASSERT_GT(p1, p2) << "First prediction must be greater than second";
> >you need to change ASSERT_GT to ASSERT_GE.
> In my understanding assert (p2<p1) means the same as ASSERT_GT(p1, p2)
> (p1>p2 <=> p2<p1)
> Could you please correct me if I am wrong?
No, you are right. Sorry, my bad. Looks good, Reviewed.
> Thank you.
> Regards, Kirill
More information about the hotspot-gc-dev