RFR(s): 8170860: Get rid of the humanReadableByteCount() method in openjdk/hotspot

Dmitry Fazunenenko dmitry.fazunenko at oracle.com
Tue Dec 20 16:15:06 UTC 2016


Thanks, Michail.

I'll fix redundant spaces.

-- Dima

On 20.12.2016 19:00, Michail Chernov wrote:
> Hi Dima,
>
> The fix looks good to me!
>
> Minor issues:
> test/gc/testlibrary/Helpers.java - redundant line 338, extra space 
> after method comment end.
> Could you please fix it before pushing? I don't need a separate review 
> for this minor issues.
>
> Thanks,
> Michail
>
> On 08/12/2016 15:47, Dmitry Fazunenenko wrote:
>> Hello,
>>
>> I'm looking for a couple of reviewers for a simple fix which 
>> eliminates the code copied from Stack Overflow:
>>
>> http://cr.openjdk.java.net/~dfazunen/8170860/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8170860
>>
>> humanReadableByteCount() method was removed. A standard JDK class 
>> NumberFormat is used instead. To make the output locale independent 
>> '_' symbol is explicitly set as the group delimiter. New output will 
>> look like:
>>
>> [allocate #1             ] init: 33_554_432, used: 5_253_664, comm: 
>> 8_388_608, freeRatio ~= 37.4%
>> [allocate #2             ] init: 33_554_432, used: 8_399_392, comm: 
>> 10_485_760, freeRatio ~= 19.9%
>> [allocate #3             ] init: 33_554_432, used: 11_545_120, comm: 
>> 13_631_488, freeRatio ~= 15.3%
>> [allocate #4             ] init: 33_554_432, used: 14_690_848, comm: 
>> 16_777_216, freeRatio ~= 12.4%
>> [allocate #5             ] init: 33_554_432, used: 17_836_576, comm: 
>> 19_922_944, freeRatio ~= 10.5%
>> [allocate #6             ] init: 33_554_432, used: 20_982_304, comm: 
>> 23_068_672, freeRatio ~= 9.0%
>> [allocate #7             ] init: 33_554_432, used: 24_128_032, comm: 
>> 26_214_400, freeRatio ~= 8.0%
>> [allocate #8             ] init: 33_554_432, used: 27_273_760, comm: 
>> 29_360_128, freeRatio ~= 7.1%
>>
>> Thanks,
>> Dima
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20161220/7431e103/attachment.htm>


More information about the hotspot-gc-dev mailing list