RFR (XXS): 8143220: Fix documentation of InitiatingHeapOccupancyPercent

Jon Masamitsu jon.masamitsu at oracle.com
Mon Feb 8 17:52:02 UTC 2016


Thanks for the changes.

On reading it again I think I would change "capacity after which " (second
line) to "capacity above which".

Regarding the meaning of  "at the next GC", since it is complicated to give
a exact definition (listing all the exceptions), maybe it would be better to
drop "at the next GC".  I tried to define it in terms of what a user 
would see but it
was a squishy definition (and not correct considering the exceptions).


On 02/08/2016 02:53 AM, Thomas Schatzl wrote:
> Hi Jon,
>    I mixed all suggestions so far into the one provided at
> http://cr.openjdk.java.net/~tschatzl/8143220/webrev.2/
> Some more comments below.
> On Fri, 2016-02-05 at 13:26 -0800, Jon Masamitsu wrote:
>> Thomas,
>> I would leave out the part about InitiatingHeapOccupancyPercent being
>> used as the initial value for IHOP because not enough data has been
>> gathered to make a better estimate.  While true today it may change
>> and I don't think it is needed as part of the description.
> Has already been removed earlier.
>>   Explaining what happens when it is 100 would be good.
> Done. I just wrote that this disables concurrent marking because that
> is probably the important effect that is important for a user.
>> I added the explanation about fragmentation (is it correct) because I
>> thought that it would come up sooner or later but you can drop it, if
>> you think it is too much.  So I would suggest.
> Done.
> Thanks,
>    Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160208/02c77f7d/attachment.htm>

More information about the hotspot-gc-dev mailing list