RFR: JDK-8149541: Use log_error() instead of log_info() when verification reports a problem
bengt.rutisson at oracle.com
Wed Feb 10 15:12:21 UTC 2016
Thanks for looking at this!
On 2016-02-10 15:41, Jesper Wilhelmsson wrote:
> Slightly unrelated to the actual change, but the "Verification failed"
> message in concurrentMarkSweepGeneration.cpp could be a bit more
> informative, similar to the message printed by the fatal call below. I
> was about to write that the log message was redundant due to this
> fatal call, but the log message in the fatal call looks like it's not
> printed on all platforms.
Sounds good. Here's an updated webrev:
and the diff compared to the last one:
> Besides that it looks good.
> Den 10/2/16 kl. 13:43, skrev Bengt Rutisson:
>> Hi everyone,
>> Could I have a couple of reviews for this change?
>> When the GC code was converted to use the unified logging framework the
>> verification logging was changed to mostly use:
>> log_info(gc, vefiy)("Information about verification failure");
>> The problem with this is that some verification, in particular in G1,
>> does not
>> report the relevant information in asserts and guarnatee messages.
>> Instead the
>> information is logged ahead of time and at some later point there is
>> like a "guarantee(false, "Verification failed.");"
>> So, to know what went wrong you really need the information that was
>> However when it is logged on log_info(gc, verify) you need to have
>> remembered to
>> set -Xlog:gc* on the command line to get this information.
>> A better solution is to log failure information at the error level.
>> That way it
>> is always logged.
More information about the hotspot-gc-dev