RFR: 8143847: Remove REF_CLEANER reference category

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Fri Jan 8 20:04:22 UTC 2016

Looks good!

Since you change vmStructs.cpp it's a good idea to run some SA test just to make 
sure there is no use of the deleted field in there. There's a bunch of jtreg 
tests in hotspot/test/serviceability/sa/. Last time I checked these were not run 
by jprt.

Slightly unrelated: Is it worth to make number_of_subclasses_of_ref() slightly 
more robust by adding a "REF_LAST" or similar to use in there? I guess we don't 
intend to add more reference types, but it is easy to forget to update this 
method if a new type is added last in the enum.


Den 8/1/16 kl. 20:46, skrev Kim Barrett:
> Please review this change to remove the REF_CLEANER reference
> category.  Now that JDK-8071507 has changed PhantomReferences
> (REF_PHANTOM) to also be cleared when notified, the distinction
> between REF_CLEANER and REF_PHANTOM is no longer needed.
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8143847
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8143847/webrev.00/
> Testing:

More information about the hotspot-gc-dev mailing list