Fwd: Re: RFR: JDK-8072725: Provide more granular levels for GC verification
thomas.schatzl at oracle.com
Mon Jan 11 16:17:01 UTC 2016
On Mon, 2016-01-11 at 08:09 -0800, Poonam Bajaj Parhar wrote:
> Hello Thomas,
> > Sorry for not finding this earlier, one more issue: the description
> > string of the flag in globals.hpp needs closing quotation marks at
> > the
> > end of every line. Otherwise it will contain lots of additional
> > unnecessary whitespace at the end of every "line" when printed.
The description string needs whitespace at the end of every line.
Otherwise the words at the end of a line and the first at the beginning
of the next line will not have the necessary whitespace.
"This is a test" \
will read "This is a teststring". I think the change meant to use
"This is a test " \
> > It might be useful to add a failing test run covering specifying an
> > invalid subset.
> Fixed both:
> Please take a look.
Please add a
at the end of the second test.
Looks good otherwise. I do not need to re-review these two issues.
More information about the hotspot-gc-dev