RFR: 8146728: TestPrintGCDetailsVerbose is never run by jtreg
kim.barrett at oracle.com
Tue Jan 12 18:46:33 UTC 2016
On Jan 12, 2016, at 12:19 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> On Jan 12, 2016, at 11:02 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>> Hi Kim,
>> On 2016-01-12 16:26, Kim Barrett wrote:
>>> Please review this change to allow TestPrintGCDetailsVerbose to run.
>>> Also updated the test's arguments for unified logging.
>>> Note: This change depends on the in-review fix for JDK-8146793.
>> The change looks good if we want to continue running the test with debug-builds only, but I wonder if it really makes sense to do so. I suspect that the reason we had the restriction was that Verbose was only available in debug-builds. But now when using -Xlog:gc*=trace the test should work with product builds as well, or am I missing something?
> The test was created to verify that some assertions were no longer triggered. Not product => no assertions to be triggered.
That said, there probably is some benefit to beating on (GC) logging in a product build. So sure, I’ll make that change.
While I’m at it, I’ll also update the test’s summary comment, which still refers to PrintGCDetails and Verbose.
More information about the hotspot-gc-dev