RFR(L): 8146395: Add inline qualifier in oop.hpp and fix inlining in gc files

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jan 13 22:54:28 UTC 2016


Hi

This change finishes the cleanup started in "8146401: Clean up oop.hpp: add inline directives and fix header files"
by fixing the issues in gc files.  See also https://bugs.openjdk.java.net/browse/JDK-8146395 and the discussion
of this change in the rt mailing list: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017440.html

Most issues can be fixed by including the proper .inline.hpp header or moving a function there.

I added new files src/share/vm/gc/shared/referenceProcessor.inline.hpp and g1SATBCardTableModRefBS.inline.hpp.

I moved the following methods to their .cpp files. In case someone considers these
performance relevant, I will add an inline.hpp file for them:
  PromotedObject::next and ::setNext    --> promotionInfo.cpp
  ObjectStartArray::object_start        --> objectStartArray.cpp
  FillClosure::do_addr to               --> psParallelCompact.cpp (ok, only used here)
  ageTable::add                         --> ageTable.cpp
  KlassSizeStats::count_array / ::count --> heapInspection.cpp

Please review this change.  I please need a sponsor.
http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.01/

Best regards,
  Goetz Lindenmaier

(The webrev messed up some change comments, the diffs and patch are fine, though.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160113/1e3114d2/attachment.htm>


More information about the hotspot-gc-dev mailing list