RFR: JDK-8147000: VM crashes during initialization trying to print log message

Bengt Rutisson bengt.rutisson at oracle.com
Thu Jan 14 08:22:52 UTC 2016

Hi Kim,

On 2016-01-13 23:57, Kim Barrett wrote:
> On Jan 13, 2016, at 4:31 PM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
>> Hi everyone,
>> Could I have a couple of reviews for this change to fix GC logging during startup?
>> http://cr.openjdk.java.net/~brutisso/8147000/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8147000
>> A recent fix in hs-rt, 8146222, exposes a problem with how the GCId::print_prefix() method checks whether it is safe to access the current thread.
>> ThreadLocalStorage::is_initialized() does not guarantee that that ThreadLocalStorage::thread() will not return NULL.
>> Changed to use Thread::current_or_null() instead. Thanks David Holmes for pointing this out.
>> Bengt
> Looks good.

Thanks for looking at this!

I got an off-line review from David Holmes. He pointed out that the 
include of threadLocalStorage.hpp can be removed.

I've removed that and will push this now.



More information about the hotspot-gc-dev mailing list