RFR (S): 8141421: Various test fail with OOME on win x86

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 21 13:19:26 UTC 2016

Hi Derek,

On Wed, 2016-01-20 at 14:15 -0500, Derek White wrote:
> Updated webrev: Print out values in lock assertion failure messages
> (see EOM for details)
> This is a small fix for a (malloc) memory leak that is causing a
> variety of crashes.
> This also improves memory tracking slightly, and adds asserts that
> clarify the expected locking usage of g1CodeCacheRemSet.
> BUG: JDK-8141421 Various test fail with OOME on win x86
> Webrev: http://cr.openjdk.java.net/~drwhite/8141421/webrev.01/
> Testing jprt, aurora.

I would prefer if the assert messages are not multi-line messages. I
like their content, but I would think it is okay to keep them in a
single line separated by commas.

I do not need a re-review for reformatting those messages.

Looks good.


More information about the hotspot-gc-dev mailing list