RFR (S): 8142749: HeapRegion cleanup

Всеволод Толстопятов qwwdfsad at gmail.com
Thu Jun 9 08:26:07 UTC 2016

Thanks for review and sponsoring!

> Note that at the moment are past the JDK9 FC date, and we should not
> integrate enhancements right now. There is no process at the moment if
> and how these can be integrated. So it may take a while to push the
> change.

Should I wait until JDK10 forest and ping someone? Should I update webrev
with includes cleanup now or wait until new forest?
Does it make sense to keep making reviews for simple bugs (e.g. like
JDK-8151045) or it's better to wait until new forest (note that I'm not
openjdk author yet, so these questions could have obvious answers)?

Best regards,
Tolstopyatov Vsevolod

On Wed, Jun 8, 2016 at 12:51 AM, Derek White <derek.white at oracle.com> wrote:

> On 5/30/16 8:05 AM, Всеволод Толстопятов wrote:
> Hi all,
> Please review and sponsor this change for JDK-8142749.
> Note that not only HeapRegion::_predicted_bytes_to_copy related code was
> removed, but also some unused (since the first commit) method/class
> parameters and HeapRegion::object_iterate_mem_careful method. All changed
> files contain at least several unused includes, but I'm not sure it's
> applicable to remove them in this patch.
> CR: https://bugs.openjdk.java.net/browse/JDK-8142749
> Webrev:
> http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8142749/webrev.00/
> Testing: hotspot_gc tests
> --
> Best regards,
> Tolstopyatov Vsevolod
> Looks good!
>  - Derek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160609/31a0d21c/attachment.htm>

More information about the hotspot-gc-dev mailing list