RFR(s): 8151283: Implement setting jtreg @requires property vm.isG1Supported.

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Thu Jun 16 13:34:08 UTC 2016


Hi Michail,

This is TEST.ROOT file, which defines itself what is the root for libraries:

   48 # Path to libraries in the topmost test directory. This is needed so @library
   49 # does not need ../../ notation to reach them
   50 external.lib.roots = ../../

So, for the stuff like VMProps we need to use "../.." in paths

Thanks,
Dima

On 16.06.2016 16:20, Michail Chernov wrote:
> Hi Dima,
>
> I have a question about paths:
>
>   requires.extraPropDefns = ../../test/jtreg-ext/requires/VMProps.java
> -requires.properties=sun.arch.data.model
> +requires.extraPropDefns.bootlibs = ../../test/lib/sun
>
> Do we need to use relative paths instead of full? We use full path in 
> tests:
>
> TestSmallHeap.java: * @library /testlibrary /test/lib 
> /test/lib/share/classes
>
> Thanks,
> Michail
>
> On 06/14/2016 07:14 PM, Dmitry Fazunenko wrote:
>> Hi Stefan,
>>
>> The idea of 'vm.gc.X.acceptable' was an ability to introduce other GC 
>> related properties like 'supported', 'default', 'setByErgonomics', 
>> 'deprecated', etc.
>> But setting 'vm.gc.X' won't prevent us from adding  'vm.gc.X.Y' later 
>> when needed.
>>
>> I fully agree:   @requires vm.gc.G1 looks much nicer and causes less 
>> questions.
>>
>> New edition:
>> http://cr.openjdk.java.net/~dfazunen/8151283/webrev.01/
>>
>> Thanks for suggestion that,
>> Dima
>>
>>
>> On 13.06.2016 10:46, Stefan Johansson wrote:
>>> Hi Dima,
>>>
>>> I don't know the code and the way this is invoked good enough to do 
>>> a proper review, but I have a style comment. Wouldn't it be nice to 
>>> only call the value "vm.gc.G1", and have:
>>> @requires vm.gc.G1
>>>
>>> I feel that "acceptable" provide very little information and what we 
>>> want to @require is that the test is only run with G1 (when 
>>> supported) and I think that is clear from such syntax. Comments?
>>>
>>> Thanks,
>>> Stefan
>>>
>>> On 2016-06-10 18:04, Dmitry Fazunenko wrote:
>>>> Hello,
>>>>
>>>> I'm looking for a couple of Reviewers for a simple change, which 
>>>> allows to skip tests depending on non supported garbage collectors.
>>>>
>>>> http://cr.openjdk.java.net/~dfazunen/8151283/webrev.00/
>>>> https://bugs.openjdk.java.net/browse/JDK-8151283
>>>>
>>>> The fix introduces four new requires boolean properties:
>>>>      vm.gc.G1.acceptable
>>>>      vm.gc.Serial.acceptable
>>>>      vm.gc.Parallel.acceptable
>>>>      vm.gc.ConcMarkSweep.acceptable
>>>> Which are set by the jtreg plugin prior the test execution starts.
>>>> After that fix we will be able to replace in tests:
>>>>    @requires vm.gc == null | vm.gc == "G1"
>>>> with
>>>>    @requires vm.gc.G1.acceptable
>>>>
>>>> 'vm.gc.G1.acceptable' will be evaluated to 'false' not only if 
>>>> other GC is set externally, but also if G1 is not supported.
>>>> In other words the fix allows not to run GC specific tests in not 
>>>> applicable configurations.
>>>>
>>>> Thanks,
>>>> Dima
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160616/ac21c52d/attachment.htm>


More information about the hotspot-gc-dev mailing list