RFR(s): 8151283: Implement setting jtreg @requires property vm.isG1Supported.
thomas.schatzl at oracle.com
Tue Jun 21 10:34:33 UTC 2016
On Tue, 2016-06-21 at 00:29 +0300, Dmitry Fazunenko wrote:
> Thanks a lot for the review!
> On 20.06.2016 23:35, Igor Ignatyev wrote:
> > Dima,
> > the fix looks good to me, thanks for implementing that. I have a
> > question about -Xbootclasspath/a:bootClasses, is it required? I
> > thought classes from requires.extraPropDefns.bootlibs will be added
> > to BCP by jtreg.
> Yes, it's required. We might decided for example to use
> -Xbootclasspath/p: instead.
> bootClasses - is the name of the local folder (under scratch dir)
> where classes from the 'requires.extraPropDefns.bootlibs' will be
> compiled to.
> And I haven't mentioned, that I introduced a field, which is
> currently unused:
> private static final WhiteBox WB = WhiteBox.getWhiteBox();
> This is for the simplification of use in the future.
thanks for clarifying this - I asked myselves for the reason of that
I would prefer to have unused code in the change at hand unless
More information about the hotspot-gc-dev