Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily

Derek White derek.white at
Tue Jun 21 19:22:45 UTC 2016

On 6/9/16 4:33 AM, Erik Helin wrote:
> On 2016-06-08, Jon Masamitsu wrote:
>> The error handling in add_workers() was not treating the non-initializing
>> case correctly.  If in the non-initializing case, it is OK to fail the
>> creation
>> of additional threads but the number of created threads should not be
>> incremented nor non-existent thread started.
> Should we add some logging in case the code fail to create a worker
> thread (in the non initializing case)?
> Thanks,
> Erik
>> Tested with gc_test_suite with UseDynamicGCThreads turned on.
>> Thanks.
>> Jon

Hi Jon,

Looks good, but I agree with Eric that logging would be nice.

  - Derek

More information about the hotspot-gc-dev mailing list