Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily
jon.masamitsu at oracle.com
Tue Jun 21 20:52:35 UTC 2016
On 6/21/2016 12:22 PM, Derek White wrote:
> On 6/9/16 4:33 AM, Erik Helin wrote:
>> On 2016-06-08, Jon Masamitsu wrote:
>>> The error handling in add_workers() was not treating the
>>> case correctly. If in the non-initializing case, it is OK to fail the
>>> of additional threads but the number of created threads should not be
>>> incremented nor non-existent thread started.
>> Should we add some logging in case the code fail to create a worker
>> thread (in the non initializing case)?
>>> Tested with gc_test_suite with UseDynamicGCThreads turned on.
> Hi Jon,
> Looks good, but I agree with Eric that logging would be nice.
Thanks for the review. Unfortunately there is more code than I've
fixed that need to tolerate thread creation failure so I'm still working
on a complete fix.
> - Derek
More information about the hotspot-gc-dev