RFR: 8168396: Unexpected OOME in GcCauseTest02 and GcTest02

Michail Chernov michail.chernov at oracle.com
Wed Nov 16 18:56:47 UTC 2016

Hi Thomas,

Thank you for reviewing this.
I added necessary @requires to both GcCauseTes02.java and GcTest02.java 
since System.gc() was added to each of them.
Checked locally - tests were being excluded as expected with 

Incremental: http://cr.openjdk.java.net/~mchernov/8168396/webrev.02_01/
Full: http://cr.openjdk.java.net/~mchernov/8168396/webrev.02/


On 16/11/2016 17:07, Thomas Schatzl wrote:
> Hi Michail,
> On Mon, 2016-10-31 at 15:44 +0300, Michail Chernov wrote:
>> Thank you very much for reviewing this!
>> Could someone of reviewers please take a look at this change. This
>> issue is integration blocker.
>    looks good but for some tests inexplicably not have an @requires
> ExplicitGCInvokesConcurrent != true.
> I think at least GcCauseTest02 should have. It does a system.gc at the
> end, so the jstat output will not reflect the true value of heap
> dimensions.
> Thanks,
>    Thomas

More information about the hotspot-gc-dev mailing list