RFR(S): 8159817: Convert FreeRegionList_test to GTest

Kim Barrett kim.barrett at oracle.com
Thu Oct 20 18:59:11 UTC 2016

> On Oct 19, 2016, at 5:19 PM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
> Dear all, Kim,
> After the discussion on Gtest and a few fixes which improved assert/guarantee behavior if they were triggered in gtest I made a new version of this fix.
> Here are a new WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8159817/webrev.03/
> Changes:
> 1. Instead of new macro I added a check which prevents the test to be run if G1 is not the current GC
> 2. Since verify_list is uses guarantee it could be considered safe to be used in gtests.
> Could you please let me know your opinion?

Looks good.

Just one tiny nit; no need for a new webrev for this:

  46   G1RegionToSpaceMapper* bot_storage =
  47       G1RegionToSpaceMapper::create_mapper(bot_rs,

Line 47 indented 4; should be 2.


More information about the hotspot-gc-dev mailing list