[10] RFR (XS): 8180366: [TESTBUG] gc/g1/humongousObjects/TestHumongousClassLoader should not be run with class unloading disabled

Kevin Walls kevin.walls at oracle.com
Wed Aug 16 12:24:47 UTC 2017


Great, and in our other conversation Muthu you had tested it and it 
worked as expected, so looks good.

Thanks
Kevin


On 16/08/2017 12:10, Dmitry Fazunenko wrote:
> Hi Muthusamy,
>
> new change looks good to me.
> To make it look perfect you need to update copyrights - add 2017 :)
> No separate review is required for that.
>
> Thanks,
> Dima
>
> On 16.08.2017 12:59, Muthusamy Chinnathambi wrote:
>>
>> Hi,
>>
>> Thanks for the review. I did not realize the difference between the two.
>>
>> Please find the updated webrev at 
>> http://cr.openjdk.java.net/~shshahma/Muthu/8180366/webrev.02/ 
>> <http://cr.openjdk.java.net/%7Eshshahma/Muthu/8180366/webrev.02/>
>>
>> Regards,
>>
>> Muthusamy C
>>
>> *From:*Dmitry Fazunenko [mailto:dmitry.fazunenko at gmail.com]
>> *Sent:* Thursday, August 10, 2017 3:11 AM
>> *To:* Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>; 
>> hotspot-gc-dev at openjdk.java.net
>> *Cc:* David Buck <david.buck at oracle.com>
>> *Subject:* Re: [10] RFR (XS): 8180366: [TESTBUG] 
>> gc/g1/humongousObjects/TestHumongousClassLoader should not be run 
>> with class unloading disabled
>>
>> Hi Muthusamy,
>>
>> To skip running a test if "-XX:-ClassUnloading" is given it's better 
>> to say:
>>
>> @requires vm.opt.ClassUnloading != false
>>
>> This will allow to keep the test running if no 'ClassUnloading' VM 
>> flag is specified.
>>
>> Thanks,
>> Dima
>>
>> On 09.08.2017 14:36, Muthusamy Chinnathambi wrote:
>>
>>     Hi,
>>
>>     Please review this trivial change for the fix of bug 'JDK-8180366 [TESTBUG] gc/g1/humongousObjects/TestHumongousClassLoader should not be run with class unloading disabled'
>>
>>     Summary:
>>
>>     This testcase(TestHumongousClassLoader.java) checks that unreachable classes and unreachable humongous class loader are unloaded after GC.  Hence we need to have class unloading enabled for the correctness of the test. The fix is to prohibit execution of the test if class unloading is disabled.
>>
>>     jdk10 bug:https://bugs.openjdk.java.net/browse/JDK-8180366
>>
>>     webrev link:http://cr.openjdk.java.net/~shshahma/Muthu/8180366/webrev.00/
>>     <http://cr.openjdk.java.net/%7Eshshahma/Muthu/8180366/webrev.00/>
>>
>>     Testing: I have manually confirmed that jtreg will no longer run the test if -XX:-ClassUnloading is used.
>>
>>     Regards,
>>
>>     Muthusamy C
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170816/de2bdd81/attachment.htm>


More information about the hotspot-gc-dev mailing list