RFR(xs): 8186465: Each j.l.Reference elapsed time log is incorrect

Stefan Karlsson stefan.karlsson at oracle.com
Wed Aug 23 21:08:01 UTC 2017

Hi Sangheon,

On 2017-08-23 23:04, sangheon.kim wrote:
> Hi all,
> Could I have some reviews for this tiny fix?
> The problem is each j.l.References has wrong time log as related 
> function is using wrong variable.
> Actually it should be using '_ref_proc_time_ms' but accidentally using 
> '_par_phase_time_ms'. Setter is using correct one but getter is 
> referring wrong one.
> CR: https://bugs.openjdk.java.net/browse/JDK-8186465
> webrev: http://cr.openjdk.java.net/~sangheki/8186465/webrev.0/
> Testing: manually checked log values

Looks good, but I think you should add a regression test for this. Maybe 
the test could at least verify that the sub-phases are not larger than 
the enclosing phase?


> Thanks,
> Sangheon

More information about the hotspot-gc-dev mailing list