RFR: 8183539: Remove G1RemSet::_into_cset_dirty_card_queue_set

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jul 4 15:24:56 UTC 2017

Hi Erik,

On Tue, 2017-07-04 at 13:40 +0200, Erik Helin wrote:
> Hi all,
> here comes a simple patch (just removing code) with a quite
> complicated justification :) So grab a cup of coffee, take out that
> good old pen and paper (it is almost impossible to convince yourself
> that this is correct without drawing) and enjoy the following little
> text:
[... long explanation...]
> Patch: http://cr.openjdk.java.net/~ehelin/8183539/00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8183539
> Testing: make test TEST=hotspot_gc on Linux x86-64 fastdebug

  while I think the explanation is good, and actually we discussed this
together, some more testing would be nice ;) Something like gcbasher
with G1EvacuationFailureALot.

Minor nit: g1RemSet.cpp:710 the "return" statement is superfluous.
(although I have already a change in mind that re-adds a return value


More information about the hotspot-gc-dev mailing list