RFR (XS): 8183127: UpdateRSetDeferred should not enqueue cards for NULL references

Mikael Gerdin mikael.gerdin at oracle.com
Wed Jul 5 08:30:14 UTC 2017

Hi Thomas,

On 2017-07-04 17:25, Thomas Schatzl wrote:
> Hi,
>    can I have reviews for this change that adds a NULL-check in the
> UpdateRSetDeferred closure so that we do not enqueue cards with NULL
> references in it during evacuation failure?
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8183127
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8183127/webrev/

Looks good to me. I agree that the amount of testing seems sufficient.

> Testing:
> jprt, gcbasher with G1EvacuationFailureALot for 1/2 hour
> I think this amount of testing is sufficient as the reasoning for this
> change is not *that* complicated.
> Thanks,
>    Thomas

More information about the hotspot-gc-dev mailing list