RFR: 8179387: Factor out CMS specific code from GenCollectedHeap into its own subclass

Erik Helin erik.helin at oracle.com
Fri Jul 7 12:35:21 UTC 2017

On 07/06/2017 06:23 PM, Roman Kennke wrote:
>>>> Ok to push this?
>> I just realized that your change doesn't build on Windows since you
>> didn't #include "precompiled.hpp" in cmsHeap.cpp. MSVC is really picky
>> about that.
>> /Mikael
> Uhhh.
> Ok, here's revision #3 with precompiled added in:
> http://cr.openjdk.java.net/~rkennke/8179387/webrev.03/
> <http://cr.openjdk.java.net/%7Erkennke/8179387/webrev.03/>

Hi Roman,

I just started looking :) I think GenCollectedHeap::gc_prologue and 
GenCollectedHeap::gc_epilogue should be virtual, and 
always_do_update_barrier = UseConcMarkSweepGC moved down 

What do you think?


> Roman

More information about the hotspot-gc-dev mailing list