RFR (M): 8184346: Clean up G1CMBitmap

Aleksey Shipilev shade at redhat.com
Fri Jul 14 11:12:18 UTC 2017


Hi Thomas,

On 07/14/2017 12:58 PM, Thomas Schatzl wrote:
>>> The next CR JDK-8184347 will deal with moving G1CMBitmap* into
>>> separate
>>> files.
>>  And while you're at it, you may want to move it to gc/shared and
>> renamed it to something like MarkBitmap?
>> https://bugs.openjdk.java.net/browse/JDK-8180193
>>
> 
> Not particularly against this change, but I think we should do the move
> and renaming separately when the change is actually required, i.e. just
> before there is another dependency on it.

I think this would be inconvenient, because when "another dependency" would come
in a large webrev, it would have to include the CMBitmap move too, complicating
reviews. It seems pulling the actual non-G1-specific parts to shared is good to
minimize those changes.

Would you like us to do take the CMBitmap rename and move to shared/ then, after
you do G1-local move?

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170714/d0fe0226/signature.asc>


More information about the hotspot-gc-dev mailing list