RFR(XS) 8183935: G1GCPhaseTimes and G1RootProcessor do not include macros.hpp

Thomas Schatzl thomas.schatzl at oracle.com
Mon Jul 17 14:21:37 UTC 2017

Hi Mikael,

On Mon, 2017-07-17 at 16:12 +0200, Mikael Gerdin wrote:
> Hi,
> Please review this trivial change to add includes of macros.hpp to 
> G1GCPhaseTimes and G1RootProcessor. They both the value of
> and as such should explicitly include the proper header to ensure
> that 
> it is set to the correct value.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8183935
> Webrev: http://cr.openjdk.java.net/~mgerdin/8183935/webrev.0/
> Testing: JPRT build-only

  ship it :) Although I do not think it is necessary to include
macros.hpp both in the hpp and cpp file, but not sure. It won't hurt.


More information about the hotspot-gc-dev mailing list