RFR (M): 8184346: Clean up G1CMBitmap

Aleksey Shipilev shade at redhat.com
Thu Jul 20 18:50:50 UTC 2017


On 07/20/2017 08:40 PM, Thomas Schatzl wrote:
> Webrevs:
> http://cr.openjdk.java.net/~tschatzl/8184346/webrev.2_to_3/ (diff)
> http://cr.openjdk.java.net/~tschatzl/8184346/webrev.3/ (full)

Generally good, comments:

 *) Long log_debug, log_warning, assert lines in g1CollectedHeap.cpp,
g1ConcurrentMark.cpp, g1ConcurrentMark.hpp

 *) It seems the field and method names are camel-cased and thus
style-inconsistent with the rest of the code?
625   const G1CMBitMap* const prevMarkBitMap() const { return _prevMarkBitMap; }
626   G1CMBitMap* nextMarkBitMap() const { return _nextMarkBitMap; }

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170720/12b91112/signature.asc>


More information about the hotspot-gc-dev mailing list