RFR (M): 8184346: Clean up G1CMBitmap

Aleksey Shipilev shade at redhat.com
Fri Jul 21 08:17:22 UTC 2017


On 07/21/2017 10:15 AM, Mikael Gerdin wrote:
> On 2017-07-20 20:50, Aleksey Shipilev wrote:
>> On 07/20/2017 08:40 PM, Thomas Schatzl wrote:
>>> Webrevs:
>>> http://cr.openjdk.java.net/~tschatzl/8184346/webrev.2_to_3/ (diff)
>>> http://cr.openjdk.java.net/~tschatzl/8184346/webrev.3/ (full)
>>
> 
> Looks fine to me too.
> 
>> Generally good, comments:
>>
>>   *) Long log_debug, log_warning, assert lines in g1CollectedHeap.cpp,
>> g1ConcurrentMark.cpp, g1ConcurrentMark.hpp
>>
>>   *) It seems the field and method names are camel-cased and thus
>> style-inconsistent with the rest of the code?
>> 625   const G1CMBitMap* const prevMarkBitMap() const { return _prevMarkBitMap; }
>> 626   G1CMBitMap* nextMarkBitMap() const { return _nextMarkBitMap; }
> 
> I think the idea is to perform that renaming in G1ConcurrentMark in a later
> change since this one tries to only concern G1CMBitMap.

No problem! Fix the long asserts, and I am happy with the patch.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20170721/bd69d9c3/signature.asc>


More information about the hotspot-gc-dev mailing list