[PATCH] JDK-8176571: Fine bitmaps should be allocated as belonging to mtGC

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jun 14 12:58:57 UTC 2017


On Sat, 2017-06-10 at 15:07 +0000, Milan Mimica wrote:
> Milan Mimica, Senior Software Engineer / Division Lead
> > 
> > From: Kim Barrett <kim.barrett at oracle.com>
> > Sent: Friday, June 9, 2017 03:04
> > 
> > Note that the refactoring patch doesn't apply cleanly to jdk10/hs
> > tip.
> > There's a merge conflict with the fix for JDK-8168467 (resolved
> > 2017/03/15).
> Oh, I 've developed it against jdk10/jdk10. Care to explain a bit the
> difference? Attached are patches against jdk10/hs.

jdk10/hs is the current development tree where development happens and
new changes pushed into. hs10/hs10 is the tree where public builds are
made from. Changes are regularly (at least in the typical case) merged
to jdk10/jdk10 after some additional regression testing.

> > What testing has been done?  And are there any tests you can point
> > to
> > that are directly affected?  (I already know about
> > TestArrayAllocatorMallocLimit.java.)  I'll probably want to run
> > some
> > tests using our internal test facilities as part of sponsoring.
> I have run jtreg on my laptop. There are some failures actually,
> but happens also on clean repo. I'm not aware of anything else.

I created https://bugs.openjdk.java.net/browse/JDK-8182169 for the
ArrayAllocator refactoring as I could not find an existing issue.

I uploaded a webrev of that change to

Looks good to me.

I also uploaded a webrev for JDK-8176571 based on the above to

Looks good to me too, but is there a reason to not use default parameters for the CHeapBitmap constructors?

As for testing I am going to move it through JPRT (our build and test system).


More information about the hotspot-gc-dev mailing list