RFR: 818269: Remove gcTrace.hpp include from referenceProcessor.hpp

Stefan Karlsson stefan.karlsson at oracle.com
Thu Jun 22 15:40:22 UTC 2017

On 2017-06-22 17:19, Kim Barrett wrote:
>> On Jun 22, 2017, at 4:59 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>> This mail was supposed to go to hotspot-gc-dev (To:ed) not to jdk10-dev (BCC:ed).
>> Thanks,
>> StefanK
>> On 2017-06-22 10:46, Stefan Karlsson wrote:
>>> Hi all,
>>> Please review this trivial change to remove an include of gcTrace.hpp in referenceProcessor.hpp, and changes needed to get the code to compile after that.
>>> http://cr.openjdk.java.net/~stefank/8182696/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8182696
>>> I was prototyping ways to get more type safe time durations in HotSpot and found that whenever I changed my header file, that almost all HotSpot cpp files were recompiled. I tracked it down to come from the unused include of gcTrace.hpp in referenceProcessor.hpp.
>>> We could probably also try to figure out why changes referenceProcessor.hpp triggers recompiles of the entire source code, but I'd like to leave that exercise for another day.
>>> Thanks,
>>> StefanK
> Looks good.
> There’s potential for interaction between this and 8181449, but we can sort that out if it happens.

Thanks, Kim. I'll wait until your change has been pushed, and will 
resolve any conflicts.



More information about the hotspot-gc-dev mailing list