RFR: G1HRRSFlushLogBuffersOnVerify with remembered set verification does not work

Erik Helin erik.helin at oracle.com
Fri Jun 30 09:47:37 UTC 2017

On 06/29/2017 11:37 AM, Thomas Schatzl wrote:
>> Patch: http://cr.openjdk.java.net/~ehelin/8153360/00/
>> Test: make hotspot - this is "just" removal of code
>   looks good.
> Please add a comment about what the last clause in the verification
> code actually means (heapRegion.cpp:584). Something like:
> // Reference may not have been refined into the remembered sets yet.
> // Instead of looking into all dirty card queues, we take a shortcut
> // by looking at whether the corresponding card is dirty.
> // ObjArrays may either by marked on the object header or exactly.
> (Actually I would guess the "correct" clause here would be is_array()
> and not is_objArray(), but primitive type arrays are never marked as
> they do not contain references)
> I do not need a re-review for the comment change.

Thanks for the review Thomas, I will add the comment before I push!

> Thanks,
>   Thomas

More information about the hotspot-gc-dev mailing list