RFR(XS): 8176403: [TESTBUG] gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA is referencing no longer existing group
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Mar 8 23:37:40 UTC 2017
On 3/8/17 4:34 PM, Daniel D. Daugherty wrote:
> On 3/8/17 4:31 PM, David Holmes wrote:
>> Hi Sangheon,
>> On 9/03/2017 9:24 AM, sangheon wrote:
>>> Hi all,
>>> Could I have some reviews for this change?
>>> As current TestSmallInitialHeapWithLargePageAndNUMA.java uses old test
>>> group tag, changed to use the new tag.
>> To be clear it was not a "test group tag" but a library path that is
>> wrong in the test and which has been fixed.
> But you can have a second (R)eview if you need it.
Wow! That could have been more clear...
>>> The test uses the old test group tag but it is not tested on JPRT.
>>> Because recently jprt.properties file was changed and I was using the
>>> old one.
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8176403
>>> webrev: http://cr.openjdk.java.net/~sangheki/8176403/webrev.0
>> Looks fine to me.
>> I consider this small enough to be pushed under the trivial change
>> rule - particularly as it blocks other pushes.
>>> Testing: JPRT (checked the test is ran and passed)
More information about the hotspot-gc-dev