RFR: 8191861: Move and refactor hSpaceCounters
erik.helin at oracle.com
Fri Nov 24 14:11:12 UTC 2017
On 11/24/2017 02:38 PM, Stefan Karlsson wrote:
> Hi all,
> Please review this patch to move and refactor HSpaceCounters.
> The patch moves hSpaceCounters.hpp/cpp out from gc/g1 into gc/shared, so
> that it can be reused by other GCs.
Looks good, but could you please add a local variable for the expression
that is repeated three times now in g1MonitoringSupport.cpp. I don't
need a re-review for this small additional change.
> The patch also removes the dependency between HSpaceCounters and
> GenerationCounters. The passed in GenerationCounters object was only
> used to provide the name_space of the perf counter. This patch changes
> G1 to explicitly pass in the name_space string instead of the
> This patch builds upon these two patches:
More information about the hotspot-gc-dev